----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63076/#review188816 -----------------------------------------------------------
Patch looks great! Reviews applied: [63076] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 19, 2017, 11:37 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63076/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2017, 11:37 p.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The `CreateDirectoryW` API will fail with a path of 248 characters > exactly, so this needed to be `>=`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/longpath.hpp > 446b038b0828c25208dd27f9b7f14ea2d32dfbea > 3rdparty/stout/tests/os/filesystem_tests.cpp > 0982fd5d35ae1088ec7e768e55b143166c923f8a > > > Diff: https://reviews.apache.org/r/63076/diff/2/ > > > Testing > ------- > > Tested on Windows with a patch of exactly 248 characters. > > > Thanks, > > Andrew Schwartzmeyer > >
