----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63076/#review188847 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/internal/windows/longpath.hpp Line 36 (original), 36 (patched) <https://reviews.apache.org/r/63076/#comment265839> Not yours, but s/Uniode/Unicode/. 3rdparty/stout/tests/os/filesystem_tests.cpp Lines 232 (patched) <https://reviews.apache.org/r/63076/#comment265840> Nit, this can be an `EXPECT_SOME`. - James Peach On Oct. 19, 2017, 11:37 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63076/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2017, 11:37 p.m.) > > > Review request for mesos, James Peach and Joseph Wu. > > > Bugs: MESOS-8116 > https://issues.apache.org/jira/browse/MESOS-8116 > > > Repository: mesos > > > Description > ------- > > The `CreateDirectoryW` API will fail with a path of 248 characters > exactly, so this needed to be `>=`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/longpath.hpp > 446b038b0828c25208dd27f9b7f14ea2d32dfbea > 3rdparty/stout/tests/os/filesystem_tests.cpp > 0982fd5d35ae1088ec7e768e55b143166c923f8a > > > Diff: https://reviews.apache.org/r/63076/diff/2/ > > > Testing > ------- > > Tested on Windows with a patch of exactly 248 characters. > > > Thanks, > > Andrew Schwartzmeyer > >
