----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63238/#review189041 -----------------------------------------------------------
PASS: Mesos patch 63238 was successfully built and tested. Reviews applied: `['63238']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63238 - Mesos Reviewbot Windows On Oct. 24, 2017, 7:59 a.m., Raluca Miclea wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63238/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2017, 7:59 a.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-3442 > https://issues.apache.org/jira/browse/MESOS-3442 > > > Repository: mesos > > > Description > ------- > > I checked #ifdefs in order to decide what tests to build and run on > Window and Posix systems respectively. > For Windows tests I mainly replaced the "slash" path separator with > "backslash". > I extracted common assertion before the #ifdef directive. > > > Diffs > ----- > > 3rdparty/stout/tests/path_tests.cpp > f8c14d5aefe0b49adb778da784143a328c96183d > > > Diff: https://reviews.apache.org/r/63238/diff/1/ > > > Testing > ------- > > Modified Tests: > TEST(PathTest, Basename) > TEST(PathTest, Dirname) > TEST(PathTest, Extension) > TEST(PathTest, Join) > > > Thanks, > > Raluca Miclea > >
