-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63238/
-----------------------------------------------------------
(Updated Oct. 26, 2017, 10:33 a.m.)
Review request for mesos and Andrew Schwartzmeyer.
Changes
-------
addressed review
Bugs: MESOS-3442
https://issues.apache.org/jira/browse/MESOS-3442
Repository: mesos
Description
-------
I checked #ifdefs in order to decide what tests to build and run on
Window and Posix systems respectively.
For Windows tests I mainly replaced the "slash" path separator with
"backslash".
I extracted common assertion before the #ifdef directive.
Diffs (updated)
-----
3rdparty/stout/tests/flags_tests.cpp 88c8ee57c2bf328251513761498ef98d774be006
3rdparty/stout/tests/path_tests.cpp f8c14d5aefe0b49adb778da784143a328c96183d
Diff: https://reviews.apache.org/r/63238/diff/2/
Changes: https://reviews.apache.org/r/63238/diff/1-2/
Testing
-------
Modified Tests:
TEST(PathTest, Basename)
TEST(PathTest, Dirname)
TEST(PathTest, Extension)
TEST(PathTest, Join)
Thanks,
Raluca Miclea
