----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/#review188981 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/containerizer.cpp Lines 757-758 (patched) <https://reviews.apache.org/r/55334/#comment266344> we don't quote the containerID since it was generated by the agent or executor, not by users. src/slave/containerizer/mesos/containerizer.cpp Lines 764-765 (patched) <https://reviews.apache.org/r/55334/#comment266345> ditto. src/slave/containerizer/mesos/containerizer.cpp Lines 764-765 (patched) <https://reviews.apache.org/r/55334/#comment266348> how about: ``` LOG(INFO) << "No container config is recovered for container " << containerId << ", image pruning will be disabled."; ``` src/slave/containerizer/mesos/containerizer.cpp Lines 765 (patched) <https://reviews.apache.org/r/55334/#comment266341> we don't have a period at the end for `LOG(INFO)`. src/slave/containerizer/mesos/containerizer.cpp Line 793 (original), 811 (patched) <https://reviews.apache.org/r/55334/#comment266350> not yours. mind add the containerID here? src/slave/containerizer/mesos/containerizer.cpp Lines 819 (patched) <https://reviews.apache.org/r/55334/#comment266349> add containerID? src/slave/containerizer/mesos/containerizer.cpp Lines 823 (patched) <https://reviews.apache.org/r/55334/#comment266352> do we need to mention image pruning will be disabled? src/slave/containerizer/mesos/containerizer.cpp Lines 860 (patched) <https://reviews.apache.org/r/55334/#comment266354> s/config/container config/g src/slave/containerizer/mesos/containerizer.cpp Lines 861 (patched) <https://reviews.apache.org/r/55334/#comment266353> remove `this means`. src/slave/containerizer/mesos/containerizer.cpp Lines 862 (patched) <https://reviews.apache.org/r/55334/#comment266342> ditto. src/slave/containerizer/mesos/containerizer.cpp Lines 1113-1120 (original), 1152-1164 (patched) <https://reviews.apache.org/r/55334/#comment266337> After looking at the slave code. it seems to me we can remove the whole part and the TODO. Not yours. this was from a tech debt when we combined the launch() method https://github.com/apache/mesos/commit/17ffb97ae7eda78edf85b204eba35bc59649a479 src/slave/containerizer/mesos/containerizer.cpp Lines 1163 (patched) <https://reviews.apache.org/r/55334/#comment266343> ditto. src/slave/containerizer/mesos/containerizer.cpp Lines 1271 (patched) <https://reviews.apache.org/r/55334/#comment266338> could we move it below `CHECK_EQ(container->state, PROVISIONING);`? src/slave/containerizer/mesos/containerizer.cpp Lines 1321 (patched) <https://reviews.apache.org/r/55334/#comment266339> good catch/ src/slave/containerizer/mesos/paths.cpp Lines 279-280 (original), 282-283 (patched) <https://reviews.apache.org/r/55334/#comment266002> mind add the containerID? src/slave/containerizer/mesos/paths.cpp Lines 310-311 (patched) <https://reviews.apache.org/r/55334/#comment266003> ditto. src/slave/containerizer/mesos/paths.cpp Lines 467-468 (patched) <https://reviews.apache.org/r/55334/#comment265921> extra newline? - Gilbert Song On Oct. 19, 2017, 9:41 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55334/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2017, 9:41 p.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6894 > https://issues.apache.org/jira/browse/MESOS-6894 > > > Repository: mesos > > > Description > ------- > > This patch includes the following change: > - Checkpointed `ContainerConfig` used to launch a container; > - Added helper function to read checkpointed `ContainerConfig`; > - Recovered `ContainerConfig`. > - Make `ContainerConfig` Option in `Container` struct to indicate whether > recovered. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 6d356ccf82f36df8c6f558fb0ace7d9f982a3d6b > src/slave/containerizer/mesos/containerizer.cpp > 78fdd21f8b7ede4beedff31ba2b488ffebd4ea31 > src/slave/containerizer/mesos/paths.hpp > a03f15e01e8eb8a1326baad8d7db96a79d785482 > src/slave/containerizer/mesos/paths.cpp > 0c61c20c345a327ec469b382558aaeed0280e754 > > > Diff: https://reviews.apache.org/r/55334/diff/11/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
