----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/#review190212 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/containerizer.cpp Lines 777 (patched) <https://reviews.apache.org/r/55334/#comment267521> Let's use VLOG(1) instead since there might be a lot of containers. src/slave/containerizer/mesos/containerizer.cpp Line 807 (original), 839-842 (patched) <https://reviews.apache.org/r/55334/#comment267520> Seems like you forget to remove these. src/slave/containerizer/mesos/containerizer.cpp Lines 878 (patched) <https://reviews.apache.org/r/55334/#comment267522> ditto. src/slave/containerizer/mesos/paths.hpp Lines 48-63 (original), 48-63 (patched) <https://reviews.apache.org/r/55334/#comment267503> could you update this comment? - Gilbert Song On Oct. 27, 2017, 11 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55334/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2017, 11 a.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6894 > https://issues.apache.org/jira/browse/MESOS-6894 > > > Repository: mesos > > > Description > ------- > > This patch includes the following change: > - Checkpointed `ContainerConfig` used to launch a container; > - Added helper function to read checkpointed `ContainerConfig`; > - Recovered `ContainerConfig`. > - Make `ContainerConfig` Option in `Container` struct to indicate whether > recovered. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 6d356ccf82f36df8c6f558fb0ace7d9f982a3d6b > src/slave/containerizer/mesos/containerizer.cpp > 100e3bbda543d87808da9ff6bea42da5099ea8c5 > src/slave/containerizer/mesos/paths.hpp > a03f15e01e8eb8a1326baad8d7db96a79d785482 > src/slave/containerizer/mesos/paths.cpp > 0c61c20c345a327ec469b382558aaeed0280e754 > > > Diff: https://reviews.apache.org/r/55334/diff/13/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
