> On Sept. 25, 2017, 6:23 p.m., Gilbert Song wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp > > Line 714 (original), 714-720 (patched) > > <https://reviews.apache.org/r/55335/diff/4/?file=1786808#file1786808line714> > > > > will it look cleaner if use `createTask()` helper? > > Zhitao Li wrote: > I created a local helper function. All `createTask()` helpers requires > some `resources` to work which is not really applicable right now.
we can leverage it by using zero resources. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review186191 ----------------------------------------------------------- On Sept. 26, 2017, 1:14 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55335/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 1:14 p.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6894 > https://issues.apache.org/jira/browse/MESOS-6894 > > > Repository: mesos > > > Description > ------- > > These tests were using a `TaskInfo` field which is missing required > protobuf fields. After the previous patch begins to checkpoint > `ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed, > thus caused these tests to fail. > > This patch backfills these fields to make these tests pass. > > > Diffs > ----- > > src/tests/containerizer/mesos_containerizer_tests.cpp > e61a85df6ec5308ccd2832e66df803b0ad7b53ee > > > Diff: https://reviews.apache.org/r/55335/diff/6/ > > > Testing > ------- > > GTEST_FILTER="MesosContainerizer*" make check > > > Thanks, > > Zhitao Li > >
