> On Oct. 17, 2017, 8:48 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 57-58 (patched) > > <https://reviews.apache.org/r/62502/diff/2/?file=1854486#file1854486line57> > > > > These two are not no needed for now. Let's remove it for now.
Also, since we don't do unpublish, the current semantics of the `PUBLISH` event is that the agent notifies a resource provider about ALL resources that needs to be in the "published" state. That means the resources may comes from all frameworks and there is no single `framework_id` that we can assign to this event. If we want to keep it the same in the future, then we probably need to change the interface of the resource allocator to avoid passing in `framework_id`s. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review188386 ----------------------------------------------------------- On Oct. 13, 2017, 12:01 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62502/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2017, 12:01 p.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu. > > > Bugs: MESOS-8089 > https://issues.apache.org/jira/browse/MESOS-8089 > > > Repository: mesos > > > Description > ------- > > Before launching a task that use resource provider resources, the Mesos > master will instruct the resource provider to make these resources > available for the task. External resource providers will checkpoint > informations to be able to reconcile resource usage in case of a > failover. Resource providers will acknowledge the 'PUBLISH'/'UNPUBLISH' > operations by sending back 'PUBLISHED'/'UNPUBLISHED' together with > the UUID of the operation. > > > Diffs > ----- > > include/mesos/resource_provider/resource_provider.proto > f5a9073075327019fd133bd51265f695ef464845 > include/mesos/v1/resource_provider/resource_provider.proto > e5cbede5b6e57a8641fca1ebfee5454f292cc24c > src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3 > src/resource_provider/storage/provider.cpp > 46224997430ac0c568904d80014166a6f059907f > src/resource_provider/validation.cpp > d2927227f60ab0d4ae2481ad73a31ee444b48ee0 > src/tests/mesos.hpp 24d220e292bc1e137992e8f81484477b62bd0896 > > > Diff: https://reviews.apache.org/r/62502/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
