----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62775/#review189774 -----------------------------------------------------------
LGTM, just two small comments: 1) The `TASK_STARTING` changes have landed, so we'll have to update the test. 2) There's a new helper method that we should use to create the `KILL` call. src/tests/default_executor_tests.cpp Lines 1288 (patched) <https://reviews.apache.org/r/62775/#comment267002> The default executor now sends a `TASK_STARTING` update, so we have to update this test. src/tests/default_executor_tests.cpp Lines 1358-1367 (patched) <https://reviews.apache.org/r/62775/#comment267001> Nit: this should call the new `createCallKill` helper method. - Gaston Kleiman On Oct. 16, 2017, 1:36 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62775/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 1:36 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-7975 > https://issues.apache.org/jira/browse/MESOS-7975 > > > Repository: mesos > > > Description > ------- > > Added a test `ROOT_NoTransitionFromKillingToFinished`. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 68312010a45df5dbdb6d9d4c49d1faa5d8c60472 > src/tests/kill_policy_test_helper.cpp > a1880595ff015475f1ba49437d49f7397da19422 > > > Diff: https://reviews.apache.org/r/62775/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
