-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62775/
-----------------------------------------------------------
(Updated Nov. 1, 2017, 7:45 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Changes
-------
Addressed review comments and updated testing section.
Bugs: MESOS-7975
https://issues.apache.org/jira/browse/MESOS-7975
Repository: mesos
Description
-------
Added a test `ROOT_NoTransitionFromKillingToFinished`.
Diffs (updated)
-----
src/tests/default_executor_tests.cpp f485b613084331c18781c2f0070d049061179050
src/tests/kill_policy_test_helper.cpp
a1880595ff015475f1ba49437d49f7397da19422
Diff: https://reviews.apache.org/r/62775/diff/3/
Changes: https://reviews.apache.org/r/62775/diff/2-3/
Testing (updated)
-------
[ RUN ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
I1101 19:07:49.244680 24316 executor.cpp:192] Version: 1.5.0
I1101 19:07:49.277947 24336 default_executor.cpp:191] Received SUBSCRIBED event
I1101 19:07:49.281920 24336 default_executor.cpp:195] Subscribed executor on
workstation
I1101 19:07:49.282701 24336 default_executor.cpp:191] Received LAUNCH_GROUP
event
I1101 19:07:49.286540 24330 default_executor.cpp:402] Setting
'MESOS_CONTAINER_IP' to: 10.0.2.5
I1101 19:07:49.313779 24336 default_executor.cpp:191] Received ACKNOWLEDGED
event
I1101 19:07:49.342092 24331 default_executor.cpp:191] Received ACKNOWLEDGED
event
I1101 19:07:49.374323 24334 default_executor.cpp:640] Successfully launched
tasks [ aebaff2e-92fd-47e6-8423-48ceeb21f231,
e7db282a-dc45-4a52-a48d-58e58c27f556 ] in child containers [
dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675,
dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 ]
I1101 19:07:49.386710 24337 default_executor.cpp:713] Waiting for child
container
dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675 of
task 'aebaff2e-92fd-47e6-8423-48ceeb21f231'
I1101 19:07:49.387315 24337 default_executor.cpp:713] Waiting for child
container
dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 of
task 'e7db282a-dc45-4a52-a48d-58e58c27f556'
I1101 19:07:49.446444 24331 default_executor.cpp:191] Received ACKNOWLEDGED
event
I1101 19:07:49.458606 24335 default_executor.cpp:191] Received ACKNOWLEDGED
event
I1101 19:07:49.499390 24332 default_executor.cpp:191] Received KILL event
I1101 19:07:49.499712 24332 default_executor.cpp:1172] Received kill for task
'aebaff2e-92fd-47e6-8423-48ceeb21f231'
I1101 19:07:49.500016 24332 default_executor.cpp:1057] Killing task
aebaff2e-92fd-47e6-8423-48ceeb21f231 running in child container
dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675 with
SIGTERM signal
I1101 19:07:49.500139 24332 default_executor.cpp:1079] Scheduling escalation to
SIGKILL in 3secs from now
I1101 19:07:49.501317 24332 default_executor.cpp:191] Received KILL event
I1101 19:07:49.501617 24332 default_executor.cpp:1172] Received kill for task
'e7db282a-dc45-4a52-a48d-58e58c27f556'
I1101 19:07:49.501972 24332 default_executor.cpp:1057] Killing task
e7db282a-dc45-4a52-a48d-58e58c27f556 running in child container
dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 with
SIGTERM signal
I1101 19:07:49.502081 24332 default_executor.cpp:1079] Scheduling escalation to
SIGKILL in 3secs from now
I1101 19:07:49.577337 24332 default_executor.cpp:888] Child container
dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675 of
task 'aebaff2e-92fd-47e6-8423-48ceeb21f231' completed in state TASK_KILLED:
Command terminated with signal Killed
I1101 19:07:49.577422 24332 default_executor.cpp:924] Killing task group
containing tasks [ aebaff2e-92fd-47e6-8423-48ceeb21f231,
e7db282a-dc45-4a52-a48d-58e58c27f556 ]
I1101 19:07:49.588505 24332 default_executor.cpp:888] Child container
dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 of
task 'e7db282a-dc45-4a52-a48d-58e58c27f556' completed in state TASK_KILLED:
Command terminated with signal Killed
I1101 19:07:49.588593 24332 default_executor.cpp:1017] Terminating after 1secs
[ OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (1013
ms)
[ RUN ]
ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
I1101 19:44:45.021219 24574 executor.cpp:192] Version: 1.5.0
I1101 19:44:45.062325 24591 default_executor.cpp:191] Received SUBSCRIBED event
I1101 19:44:45.066876 24591 default_executor.cpp:195] Subscribed executor on
workstation
I1101 19:44:45.067586 24591 default_executor.cpp:191] Received LAUNCH_GROUP
event
I1101 19:44:45.070425 24590 default_executor.cpp:402] Setting
'MESOS_CONTAINER_IP' to: 10.0.2.5
I1101 19:44:45.101138 24588 default_executor.cpp:191] Received ACKNOWLEDGED
event
I1101 19:44:45.120609 24588 default_executor.cpp:191] Received ACKNOWLEDGED
event
I1101 19:44:45.200438 24592 default_executor.cpp:640] Successfully launched
tasks [ bd4ea3aa-e920-4f5b-8fc1-11986c006e8f,
187e2bdc-38a4-4e3d-bb74-33fb816e31c4 ] in child containers [
decae4b4-dd75-4c12-8d8f-cfee34c3bf70.c1190d4b-8ebd-42e8-bc04-2c295318d092,
decae4b4-dd75-4c12-8d8f-cfee34c3bf70.bb89dcf8-c30d-4fe1-a42b-91e1e0ff221b ]
I1101 19:44:45.252046 24592 default_executor.cpp:713] Waiting for child
container
decae4b4-dd75-4c12-8d8f-cfee34c3bf70.c1190d4b-8ebd-42e8-bc04-2c295318d092 of
task 'bd4ea3aa-e920-4f5b-8fc1-11986c006e8f'
I1101 19:44:45.255779 24592 default_executor.cpp:713] Waiting for child
container
decae4b4-dd75-4c12-8d8f-cfee34c3bf70.bb89dcf8-c30d-4fe1-a42b-91e1e0ff221b of
task '187e2bdc-38a4-4e3d-bb74-33fb816e31c4'
I1101 19:44:45.289633 24588 default_executor.cpp:191] Received ACKNOWLEDGED
event
I1101 19:44:45.295717 24588 default_executor.cpp:191] Received ACKNOWLEDGED
event
I1101 19:44:45.355026 24589 default_executor.cpp:191] Received KILL event
I1101 19:44:45.355679 24589 default_executor.cpp:1172] Received kill for task
'bd4ea3aa-e920-4f5b-8fc1-11986c006e8f'
I1101 19:44:45.355995 24589 default_executor.cpp:1057] Killing task
bd4ea3aa-e920-4f5b-8fc1-11986c006e8f running in child container
decae4b4-dd75-4c12-8d8f-cfee34c3bf70.c1190d4b-8ebd-42e8-bc04-2c295318d092 with
SIGTERM signal
I1101 19:44:45.356132 24589 default_executor.cpp:1079] Scheduling escalation to
SIGKILL in 3secs from now
I1101 19:44:45.357436 24589 default_executor.cpp:191] Received KILL event
I1101 19:44:45.357635 24589 default_executor.cpp:1172] Received kill for task
'187e2bdc-38a4-4e3d-bb74-33fb816e31c4'
I1101 19:44:45.357844 24589 default_executor.cpp:1057] Killing task
187e2bdc-38a4-4e3d-bb74-33fb816e31c4 running in child container
decae4b4-dd75-4c12-8d8f-cfee34c3bf70.bb89dcf8-c30d-4fe1-a42b-91e1e0ff221b with
SIGTERM signal
I1101 19:44:45.358074 24589 default_executor.cpp:1079] Scheduling escalation to
SIGKILL in 3secs from now
I1101 19:44:45.519832 24592 default_executor.cpp:888] Child container
decae4b4-dd75-4c12-8d8f-cfee34c3bf70.bb89dcf8-c30d-4fe1-a42b-91e1e0ff221b of
task '187e2bdc-38a4-4e3d-bb74-33fb816e31c4' completed in state TASK_KILLED:
Command terminated with signal Killed
I1101 19:44:45.520102 24592 default_executor.cpp:924] Killing task group
containing tasks [ bd4ea3aa-e920-4f5b-8fc1-11986c006e8f,
187e2bdc-38a4-4e3d-bb74-33fb816e31c4 ]
I1101 19:44:45.521134 24592 default_executor.cpp:888] Child container
decae4b4-dd75-4c12-8d8f-cfee34c3bf70.c1190d4b-8ebd-42e8-bc04-2c295318d092 of
task 'bd4ea3aa-e920-4f5b-8fc1-11986c006e8f' completed in state TASK_KILLED:
Command terminated with signal Terminated
I1101 19:44:45.521200 24592 default_executor.cpp:1017] Terminating after 1secs
[ OK ]
ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
(1417 ms)
Thanks,
Qian Zhang
