-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60888/
-----------------------------------------------------------
(Updated Nov. 2, 2017, 8:43 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Fixed recovery for nested containers launched underneath standalone containers.
These nested containers were not being marked as `isRecoverableNestedContainer
= true` because the set of "alive" containers is determined from the
`SlaveState`, which does not include standalone containers. To fix this, the
`alive` hashset was removed, because, for the purpose of finding the top-level
container, the existing `containers_` hashmap is sufficient.
Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305
Repository: mesos
Description
-------
Although there is no way to launch standalone containers yet,
this commit outlines the expected layout of container metadata
which should be populated when launching standalone containers.
The layout is fairly simple, as standalone containers have no
framework, executor, or tasks to worry about. The sandbox directory
will live under a new top-level directory `containers` and there is
no metadata to checkpoint at the moment.
The containerizer will checkpoint a marker file (in the runtime
directory) so that it knows to recover all standalone containers.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp
100e3bbda543d87808da9ff6bea42da5099ea8c5
src/slave/containerizer/mesos/paths.hpp
a03f15e01e8eb8a1326baad8d7db96a79d785482
src/slave/containerizer/mesos/paths.cpp
0c61c20c345a327ec469b382558aaeed0280e754
src/slave/paths.hpp f000508d414daf9f943561f89c7105503a8a98b3
src/slave/paths.cpp fd546525b900cb6524fb9196d19616ef18de0f30
Diff: https://reviews.apache.org/r/60888/diff/4/
Changes: https://reviews.apache.org/r/60888/diff/3-4/
Testing
-------
See next patch and later ones too.
Thanks,
Joseph Wu
