> On Oct. 17, 2017, 10:42 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 850 (patched) > > <https://reviews.apache.org/r/60888/diff/3/?file=1858652#file1858652line852> > > > > Some isolator might be surprised by standalone containers. Is there a > > patch in this chain that checks if an isolator is standalone container > > capable?
Not in the current chain. But this is one of the next things for me to do. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60888/#review188345 ----------------------------------------------------------- On Oct. 16, 2017, 4:25 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60888/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 4:25 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7305 > https://issues.apache.org/jira/browse/MESOS-7305 > > > Repository: mesos > > > Description > ------- > > Although there is no way to launch standalone containers yet, > this commit outlines the expected layout of container metadata > which should be populated when launching standalone containers. > > The layout is fairly simple, as standalone containers have no > framework, executor, or tasks to worry about. The sandbox directory > will live under a new top-level directory `containers` and there is > no metadata to checkpoint at the moment. > > The containerizer will checkpoint a marker file (in the runtime > directory) so that it knows to recover all standalone containers. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 78fdd21f8b7ede4beedff31ba2b488ffebd4ea31 > src/slave/containerizer/mesos/paths.hpp > a03f15e01e8eb8a1326baad8d7db96a79d785482 > src/slave/containerizer/mesos/paths.cpp > 0c61c20c345a327ec469b382558aaeed0280e754 > src/slave/paths.hpp f000508d414daf9f943561f89c7105503a8a98b3 > src/slave/paths.cpp fd546525b900cb6524fb9196d19616ef18de0f30 > > > Diff: https://reviews.apache.org/r/60888/diff/3/ > > > Testing > ------- > > See next patch and later ones too. > > > Thanks, > > Joseph Wu > >
