> On Nov. 3, 2017, 2:25 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Mesos tests failed to build.
> >
> > Reviews applied: `['63340', '63341', '63342']`
> >
> > Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
> >
> > All the build artifacts available at:
> > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63342
> >
> > Relevant logs:
> >
> > -
> > [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63342/logs/mesos-tests-build-cmake-stdout.log):
> >
> > ```
> >
> > c:\dcos\mesos\mesos\src\slave\containerizer\mesos\io\switchboard.cpp(628):
> > warning C4715: 'mesos::internal::slave::IOSwitchboard::_prepare': not all
> > control paths return a value [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(75):
> > warning C4267: '=': conversion from 'size_t' to 'unsigned long', possible
> > loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(271):
> > warning C4267: 'argument': conversion from 'size_t' to 'unsigned int',
> > possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(333):
> > warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible
> > loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(216):
> > warning C4267: 'argument': conversion from 'size_t' to 'unsigned int',
> > possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(242):
> > warning C4267: 'argument': conversion from 'size_t' to 'unsigned int',
> > possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(274):
> > warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible
> > loss of data [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return':
> > conversion from 'unsigned __int64' to 'double', possible loss of data
> > (compiling source file C:\DCOS\mesos\mesos\src\common\protobuf_utils.cpp)
> > [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\files\files.cpp(703): warning C4267: 'argument':
> > conversion from 'size_t' to 'off_t', possible loss of data
> > [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return':
> > conversion from 'unsigned __int64' to 'double', possible loss of data
> > (compiling source file C:\DCOS\mesos\mesos\src\master\master.cpp)
> > [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\master\master.cpp(6099): warning C4244:
> > 'argument': conversion from 'const ::size_t' to 'double', possible loss of
> > data [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\master\master.cpp(6186): warning C4244:
> > 'argument': conversion from 'const ::size_t' to 'double', possible loss of
> > data [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\master\master.cpp(6769): warning C4244:
> > 'argument': conversion from 'const ::size_t' to 'double', possible loss of
> > data [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\master\master.cpp(8208): warning C4244:
> > 'argument': conversion from 'const ::size_t' to 'double', possible loss of
> > data [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\master\master.cpp(9748): warning C4244: 'return':
> > conversion from '::size_t' to 'double', possible loss of data
> > [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return':
> > conversion from 'unsigned __int64' to 'double', possible loss of data
> > (compiling source file C:\DCOS\mesos\mesos\src\master\quota_handler.cpp)
> > [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return':
> > conversion from 'unsigned __int64' to 'double', possible loss of data
> > (compiling source file C:\DCOS\mesos\mesos\src\master\weights_handler.cpp)
> > [C:\DCOS\mesos\src\mesos.vcxproj]
> > C:\DCOS\mesos\mesos\src\master\allocator\sorter\drf\sorter.cpp(589):
> > warning C4267: 'return': conversion from 'size_t' to 'int', possible loss
> > of data [C:\DCOS\mesos\src\mesos.vcxproj]
> >
> >
> > "C:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
> > "C:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
> > (ClCompile target) ->
> > C:\DCOS\mesos\mesos\src\common\build.cpp(51): error C2065:
> > 'BUILD_JAVA_JVM_LIBRARY': undeclared identifier
> > [C:\DCOS\mesos\src\mesos.vcxproj]
> >
> > 228 Warning(s)
> > 1 Error(s)
> >
> > Time Elapsed 00:15:23.35
> > ```
> >
> > -
> > [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63342/logs/mesos-tests-CMakeOutput.log):
> >
> > ```
> > Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
> > Creating directory "cmTC_2dd55.dir\Debug\cmTC_2dd55.tlog\".
> > InitializeBuildStatus:
> > Creating "cmTC_2dd55.dir\Debug\cmTC_2dd55.tlog\unsuccessfulbuild" because
> > "AlwaysCreate" was specified.
> > ClCompile:
> > C:\Program Files (x86)\Microsoft Visual
> > Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c
> > /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D
> > COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc
> > /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR
> > /Fo"cmTC_2dd55.dir\Debug\" /Fd"cmTC_2dd55.dir\Debug\vc141.pdb" /Gd /TP
> > /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
> > Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
> > Copyright (C) Microsoft Corporation. All rights reserved.
> >
> > cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D
> > COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc
> > /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR
> > /Fo"cmTC_2dd55.dir\Debug\" /Fd"cmTC_2dd55.dir\Debug\vc141.pdb" /Gd /TP
> > /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
> > src.cxx
> >
> > Link:
> > C:\Program Files (x86)\Microsoft Visual
> > Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe
> > /ERRORREPORT:QUEUE
> > /OUT:"C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_2dd55.exe" /INCREMENTAL
> > /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib
> > ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST
> > /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG
> > /PDB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_2dd55.pdb"
> > /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT
> > /IMPLIB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_2dd55.lib"
> > /MACHINE:X64 /machine:x64 cmTC_2dd55.dir\Debug\src.obj
> > cmTC_2dd55.vcxproj ->
> > C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_2dd55.exe
> > cmTC_2dd55.vcxproj ->
> > C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_2dd55.pdb (Full PDB)
> > FinalizeBuildStatus:
> > Deleting file "cmTC_2dd55.dir\Debug\cmTC_2dd55.tlog\unsuccessfulbuild".
> > Touching "cmTC_2dd55.dir\Debug\cmTC_2dd55.tlog\cmTC_2dd55.lastbuildstate".
> > Done Building Project
> > "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_2dd55.vcxproj" (default targets).
> >
> > Build succeeded.
> > 0 Warning(s)
> > 0 Error(s)
> >
> > Time Elapsed 00:00:01.73
> >
> > Source file was:
> > int main() { return 0; }
> > ```
> >
> > -
> > [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63342/logs/mesos-tests-CMakeError.log):
> >
> > ```
> > PrepareForBuild:
> > Creating directory "cmTC_69de7.dir\Debug\".
> > Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
> > Creating directory "cmTC_69de7.dir\Debug\cmTC_69de7.tlog\".
> > InitializeBuildStatus:
> > Creating "cmTC_69de7.dir\Debug\cmTC_69de7.tlog\unsuccessfulbuild" because
> > "AlwaysCreate" was specified.
> > ClCompile:
> > C:\Program Files (x86)\Microsoft Visual
> > Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c
> > /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D
> > UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm-
> > /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline
> > /Fo"cmTC_69de7.dir\Debug\" /Fd"cmTC_69de7.dir\Debug\vc141.pdb" /Gd /TC
> > /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
> > Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
> > Copyright (C) Microsoft Corporation. All rights reserved.
> >
> > cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS
> > /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE
> > /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline
> > /Fo"cmTC_69de7.dir\Debug\" /Fd"cmTC_69de7.dir\Debug\vc141.pdb" /Gd /TC
> > /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
> > CheckIncludeFile.c
> >
> > C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083:
> > Cannot open include file: 'pthread.h': No such file or directory
> > [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_69de7.vcxproj]
> > Done Building Project
> > "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_69de7.vcxproj" (default targets) --
> > FAILED.
> >
> > Build FAILED.
> >
> > "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_69de7.vcxproj" (default target) (1)
> > ->
> > (ClCompile target) ->
> > C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error
> > C1083: Cannot open include file: 'pthread.h': No such file or directory
> > [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_69de7.vcxproj]
> >
> > 0 Warning(s)
> > 1 Error(s)
> >
> > Time Elapsed 00:00:01.14
> >
> >
> > ```
> C:\DCOS\mesos\mesos\src\common\build.cpp(51): error C2065:
> 'BUILD_JAVA_JVM_LIBRARY': undeclared identifier
> [C:\DCOS\mesos\src\mesos.vcxproj]
Real error, investigating.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63342/#review190066
-----------------------------------------------------------
On Nov. 3, 2017, 10:31 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63342/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2017, 10:31 a.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Michael
> Park.
>
>
> Bugs: MESOS-8035
> https://issues.apache.org/jira/browse/MESOS-8035
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This resolves MESOS-8035 so that building just the `mesos-agent`, etc.
> target should correctly build its runtime dependencies (such as the
> containerizer, executor, etc.).
>
>
> Diffs
> -----
>
> src/local/CMakeLists.txt 5e5bee3b70b2407bd86d9e7ffe0d169346054942
> src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924
> src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76
>
>
> Diff: https://reviews.apache.org/r/63342/diff/2/
>
>
> Testing
> -------
>
> Cleaned build folder, built just the `mesos-agent` target on Windows and
> Linux, verified it could launch and connect to a master (built clean with
> just `--target mesos-master`. Launched a simple task via Marathon to confirm
> end-to-end support.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
