----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63565/#review190129 -----------------------------------------------------------
Fix it, then Ship it! support/mesos-tidy.sh Line 27 (original), 27 (patched) <https://reviews.apache.org/r/63565/#comment267380> Did you really intent to by default enable all checks and only explicitly blacklist some? I'd prefer if we'd instead continue to whitelist instead of blacklist (e.g., to ease upgrading the toolchain, and for explicitness). For that we'd first disable all checks with `-*` and only whitelist the checks we want enabled, e.g., `-*,foo-check,bar-check,...` - Benjamin Bannier On Nov. 6, 2017, 1:10 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63565/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 1:10 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > MesosTidy: Added some `google-*` checks to the default set of checks. > > > Diffs > ----- > > support/mesos-tidy.sh 875108ae18c583e24411264983433b902b43412c > > > Diff: https://reviews.apache.org/r/63565/diff/1/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
