> On Nov. 5, 2017, 10:55 p.m., Benjamin Bannier wrote: > > support/mesos-tidy.sh > > Line 27 (original), 27 (patched) > > <https://reviews.apache.org/r/63565/diff/1/?file=1881170#file1881170line27> > > > > Did you really intent to by default enable all checks and only > > explicitly blacklist some? > > > > I'd prefer if we'd instead continue to whitelist instead of blacklist > > (e.g., to ease upgrading the toolchain, and for explicitness). For that > > we'd first disable all checks with `-*` and only whitelist the checks we > > want enabled, e.g., > > > > `-*,foo-check,bar-check,...` > > Benjamin Bannier wrote: > To get the full list of checks, one can use `clang-tidy` (pass both some > `-checks` and `-list-checks`). The list would be pretty long, so we might > want to wrap this in some smart way for readability.
Chatted to Benjamin on Slack. We're okay with implicitly picking up more checks that are deemed default by the toolchain. We'll be the ones who are upgrading the toolchain anyway, so it would be good to see if any of the default checks fail, and disable them if we decide the check doesn't apply to us. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63565/#review190129 ----------------------------------------------------------- On Nov. 5, 2017, 4:10 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63565/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2017, 4:10 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > MesosTidy: Added some `google-*` checks to the default set of checks. > > > Diffs > ----- > > support/mesos-tidy.sh 875108ae18c583e24411264983433b902b43412c > > > Diff: https://reviews.apache.org/r/63565/diff/1/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
