----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62636/#review190257 -----------------------------------------------------------
You could probably combine this review with https://reviews.apache.org/r/62633/ , as that review is basically just plumbing the auth token from Daemon -> Local -> SLRP. And this review adds plumbing of the token (via the secret generator) from Agent -> Daemon. src/resource_provider/daemon.cpp Lines 96-99 (original), 114-118 (patched) <https://reviews.apache.org/r/62636/#comment267562> I'd consider an error at this step to be a fatal error (basically a misconfiguration), so we should fail-fast here and exit the agent. src/resource_provider/daemon.cpp Lines 207 (patched) <https://reviews.apache.org/r/62636/#comment267564> s/insteaf/instead/ src/slave/slave.cpp Line 1234 (original), 1234-1236 (patched) <https://reviews.apache.org/r/62636/#comment267557> Consider moving this comment above `start` in `daemon.hpp`. (With the side benefit of not needing to duplicate the comment in two places) - Joseph Wu On Nov. 3, 2017, 5:51 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62636/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2017, 5:51 p.m.) > > > Review request for mesos, Alexander Rojas, Greg Mann, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-8100 > https://issues.apache.org/jira/browse/MESOS-8100 > > > Repository: mesos > > > Description > ------- > > `LocalResourceProviderDaemon` now uses `Slave::secretGenerater` to > generate an authentication token for each local resource provider. The > authentication token can then be used to call the V1 agent API. In order > to generate the tokens, `LocalResourceProviderDaemon::load()` is now an > asynchronous function. > > > Diffs > ----- > > src/resource_provider/daemon.hpp ef6c356cb6ddb2594d767d7dd6052e9fd8df8263 > src/resource_provider/daemon.cpp d584eb9d7aa75522aec97277674321061b90fbed > src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 > > > Diff: https://reviews.apache.org/r/62636/diff/5/ > > > Testing > ------- > > make > > > Thanks, > > Chun-Hung Hsiao > >
