-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62636/#review191276
-----------------------------------------------------------
OK, i think we probably need to do the following given you're reusing the JWT
authenticator built for executor authn:
1) probably rename `executor_secret_key` to `jwt_secret_key` (using flag alias)
because this is used
2) if `jwt_secret_key` is not set, we should not load the JWT authenticator.
It's already an error if someone set `authencate_http_executor` but not
`jwt_secret_key`. So this sounds reasonable to me
```
string httpAuthenticators;
if (flags.http_authenticators.isSome()) {
httpAuthenticators = flags.http_authenticators.get();
#ifdef USE_SSL_SOCKET
} else if (flags.jwt_secret_key.isSome()) {
httpAuthenticators =
string(DEFAULT_BASIC_HTTP_AUTHENTICATOR) + "," +
string(DEFAULT_JWT_HTTP_AUTHENTICATOR);
#endif // USE_SSL_SOCKET
} else {
httpAuthenticators = DEFAULT_BASIC_HTTP_AUTHENTICATOR;
}
```
- Jie Yu
On Nov. 17, 2017, 12:19 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62636/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2017, 12:19 a.m.)
>
>
> Review request for mesos, Alexander Rojas, Greg Mann, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8100
> https://issues.apache.org/jira/browse/MESOS-8100
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `LocalResourceProviderDaemon` now uses `Slave::secretGenerater` to
> generate an authentication token for each local resource provider. The
> authentication token can then be used to call the V1 agent API. In order
> to generate the tokens, `LocalResourceProviderDaemon::load()` is now an
> asynchronous function.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.hpp ef6c356cb6ddb2594d767d7dd6052e9fd8df8263
> src/resource_provider/daemon.cpp d584eb9d7aa75522aec97277674321061b90fbed
> src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0
>
>
> Diff: https://reviews.apache.org/r/62636/diff/6/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
