> On Nov. 9, 2017, 9:08 a.m., Jan Schlicht wrote: > > src/master/master.cpp > > Lines 10966-10971 (patched) > > <https://reviews.apache.org/r/63689/diff/1/?file=1885181#file1885181line11074> > > > > `Master::_apply` will currently always call `Slave::apply`. This means > > that the changes above (calling `Master::_apply` for storage operation) > > will always trigger these cases. `Slave::apply` should ignore these > > operations instead of failing over. Or we move the switch to > > `Master::_apply` so that `Slave::apply` is only called for `RESERVE`, > > `UNRESERVE`, `CREATE`, `DESTROY`.
GOod catch! I updated the patch with a more future proof solution. Basically, in Slave::addOfferOperation, we'll speculatively apply the conversion to Slave (changing totalResources) for old operations. For agent that does not support RESOURCE_PROVIDER capability, we resort to the old way. I also drop the new operation if the agent is not RESOURCE_PROVIDER capable. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/#review190556 ----------------------------------------------------------- On Nov. 9, 2017, 12:02 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63689/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2017, 12:02 a.m.) > > > Review request for mesos, Benjamin Bannier and Jan Schlicht. > > > Bugs: MESOS-7235 > https://issues.apache.org/jira/browse/MESOS-7235 > > > Repository: mesos > > > Description > ------- > > Used `Master::_apply` consistently for all offer operations. > > > Diffs > ----- > > src/master/master.cpp e1381a9a4f0183548a2b8ea8431bf52b0739629f > > > Diff: https://reviews.apache.org/r/63689/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
