> On Nov. 10, 2017, 2:42 p.m., Jan Schlicht wrote: > > src/master/master.cpp > > Lines 9910-9919 (patched) > > <https://reviews.apache.org/r/63689/diff/2/?file=1886639#file1886639line10020> > > > > This should be part of `Slave::apply`, as the exact same code is used > > again in `Slave::addOfferOperation`.
I want to keep the `Slave::apply` to take conversions (instead of operations). The reason for that is because `Slave::apply` will needs to be called in offerOperationStatusUpdate as well once the terminal status update is received. I'll follow up with a patch for that. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/#review190715 ----------------------------------------------------------- On Nov. 10, 2017, 1:24 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63689/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2017, 1:24 a.m.) > > > Review request for mesos, Benjamin Bannier and Jan Schlicht. > > > Bugs: MESOS-7235 > https://issues.apache.org/jira/browse/MESOS-7235 > > > Repository: mesos > > > Description > ------- > > Used `Master::_apply` consistently for all offer operations. > > > Diffs > ----- > > src/master/master.hpp adabc593cff08f917dfe7ed73ef33729d1bd143c > src/master/master.cpp e1381a9a4f0183548a2b8ea8431bf52b0739629f > > > Diff: https://reviews.apache.org/r/63689/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
