> On Nov. 8, 2017, 11:06 a.m., Jie Yu wrote: > > src/tests/agent_container_api_tests.cpp > > Lines 88 (patched) > > <https://reviews.apache.org/r/63056/diff/2/?file=1879175#file1879175line88> > > > > Can you comment on what each field means?
I'll move the comment blob (found after the test class is defined) up above the class. > On Nov. 8, 2017, 11:06 a.m., Jie Yu wrote: > > src/tests/agent_container_api_tests.cpp > > Lines 251-291 (patched) > > <https://reviews.apache.org/r/63056/diff/2/?file=1879175#file1879175line251> > > > > Do you still need this? Can you just use LAUNCH_CONTAINER for both > > cases? Ditto below. Or you just want to exercise that path? The point is to exercise the four potential code paths: A parent container (launched via a framework, or launched via `LAUNCH_CONTAINER`) X (cartesian product) A nested container (launched via `LAUNCH_NESTED_CONTAINER`, or via `LAUNCH_CONTAINER`). It's actually a bit messier to disallow certain cases (like parent `LAUNCH_CONTAINER` with nested `LAUNCH_NESTED_CONTAINER`). And the code paths are slightly different for each combination, so it's good to test them all. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63056/#review190471 ----------------------------------------------------------- On Nov. 2, 2017, 9 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63056/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 9 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7305 > https://issues.apache.org/jira/browse/MESOS-7305 > > > Repository: mesos > > > Description > ------- > > This introduces a new test class that is parameterized based > on the type of API used to launch (1) the parent container, > (2) the nested container, and (3) the content type (like all > other API tests). The test is also parameterized based > on the enabled set of isolators. > > Because this change overlaps with existing nested container > API tests, those test(s) will be removed. > > > Diffs > ----- > > src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 > src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 > src/tests/agent_container_api_tests.cpp PRE-CREATION > src/tests/api_tests.cpp b3efac942f538bcf2594a397d54042028a7aa7a5 > > > Diff: https://reviews.apache.org/r/63056/diff/2/ > > > Testing > ------- > > make check > > On... > OSX and Ubuntu 16 > > > Thanks, > > Joseph Wu > >
