----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/#review190952 -----------------------------------------------------------
src/master/master.cpp Lines 7093 (patched) <https://reviews.apache.org/r/63732/#comment268531> This needs to handle the case where the master might have offer operations that the agent doesn't report here, e.g. after an agent failover. We should send operation feedback to frameworks in that case, indicating an error with the operation. Otherwise frameworks will receive no feedback for these operations. - Jan Schlicht On Nov. 13, 2017, 7:33 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63732/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2017, 7:33 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8207 > https://issues.apache.org/jira/browse/MESOS-8207 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.cpp e1381a9a4f0183548a2b8ea8431bf52b0739629f > > > Diff: https://reviews.apache.org/r/63732/diff/1/ > > > Testing > ------- > > `make check`, still need to implement dedicated tests. > > > Thanks, > > Benjamin Bannier > >
