> On Nov. 16, 2017, 1:43 a.m., Jie Yu wrote: > > src/master/master.cpp > > Lines 7119 (patched) > > <https://reviews.apache.org/r/63732/diff/2/?file=1893485#file1893485line7119> > > > > Ditto. You probably want to change `addOfferOperation` to not update > > total resources. That means you need to goto callsites to manually apply > > then if it's a speculative operation.
Like I commented elsewhere, let's do that in a separate chain. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/#review191131 ----------------------------------------------------------- On Nov. 15, 2017, 6:31 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63732/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2017, 6:31 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8207 > https://issues.apache.org/jira/browse/MESOS-8207 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.cpp 59a533940736f5cfd5ec31e0ed924f0b2ab13f9c > > > Diff: https://reviews.apache.org/r/63732/diff/2/ > > > Testing > ------- > > `make check`, still need to implement dedicated tests. > > > Thanks, > > Benjamin Bannier > >
