----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63768/#review190989 -----------------------------------------------------------
A few minor comments. Also please `s/reponse/response/` in the patch summary =). include/mesos/scheduler/scheduler.proto Lines 211 (patched) <https://reviews.apache.org/r/63768/#comment268574> s/master operator API/scheduler API/ include/mesos/v1/scheduler/scheduler.proto Lines 209 (patched) <https://reviews.apache.org/r/63768/#comment268575> Ditto. - Gaston Kleiman On Nov. 13, 2017, 3:25 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63768/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2017, 3:25 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan > Schlicht. > > > Bugs: MESOS-8198 > https://issues.apache.org/jira/browse/MESOS-8198 > > > Repository: mesos > > > Description > ------- > > Added 'ReconcileOfferOperations' reponse to scheduler API. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > f5dda10a076ecae53a56875d0ed4d201a1c92f12 > include/mesos/v1/scheduler/scheduler.proto > 4fa6606b0db701aebe208b962b7768da68b180ab > src/scheduler/scheduler.cpp 286a7603352a1e639a0502e496d4409be11bf9d7 > > > Diff: https://reviews.apache.org/r/63768/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
