----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63768/#review191007 -----------------------------------------------------------
Fix it, then Ship it! src/scheduler/scheduler.cpp Lines 123-124 (original), 123 (patched) <https://reviews.apache.org/r/63768/#comment268595> For consistency I think that it'd also be nice to remove the `using process::http::Request` statement. Also I noticed that we use `::Request` in this file... so removing the `using` statement and replacing `::Request` with the more explicit `process::http::Request` feels to me like an improvement. - Gaston Kleiman On Nov. 14, 2017, 1:44 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63768/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2017, 1:44 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan > Schlicht. > > > Bugs: MESOS-8198 > https://issues.apache.org/jira/browse/MESOS-8198 > > > Repository: mesos > > > Description > ------- > > This patch adds a first-class `Response` message to the scheduler API > along with its first member, the `ReconcileOfferOperations` response > message. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > f5dda10a076ecae53a56875d0ed4d201a1c92f12 > include/mesos/v1/scheduler/scheduler.proto > 4fa6606b0db701aebe208b962b7768da68b180ab > src/scheduler/scheduler.cpp 286a7603352a1e639a0502e496d4409be11bf9d7 > > > Diff: https://reviews.apache.org/r/63768/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
