----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/#review191104 -----------------------------------------------------------
src/master/master.cpp Lines 9816-9817 (original) <https://reviews.apache.org/r/63842/#comment268690> If you remove this CHECK, i'd like to see the resoures used by the operation being released. For instance, if a new operation is in non terminal status, you want to release the resources that it currently uses when removing the operation. That ensures that we don't leak any resources. - Jie Yu On Nov. 15, 2017, 5:31 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63842/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2017, 5:31 p.m.) > > > Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > During reconcilation we might be required to remove non-terminal offer > operations from bookkeeping. > > > Diffs > ----- > > src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 > src/master/master.cpp 59a533940736f5cfd5ec31e0ed924f0b2ab13f9c > src/slave/slave.cpp d8bacebc74790e955490a158c37ac0d9e75fd6b5 > > > Diff: https://reviews.apache.org/r/63842/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
