> On Nov. 18, 2017, 1:47 a.m., Jie Yu wrote: > > src/master/master.hpp > > Lines 2913-2915 (original) > > <https://reviews.apache.org/r/63842/diff/2/?file=1896902#file1896902line2913> > > > > Do you need to do the same as that in `Slave::removeOfferOperation`?
Of course. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/#review191424 ----------------------------------------------------------- On Nov. 21, 2017, 10:08 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63842/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 10:08 p.m.) > > > Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > During reconcilation we might be required to remove non-terminal offer > operations from bookkeeping. > > > Diffs > ----- > > src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d > src/master/master.cpp 7417b5d641fd4bb6d91cb0e6456c60201bbc8206 > src/slave/slave.cpp 6e9adc60f593faf1b0e56caeea04882f67af7080 > > > Diff: https://reviews.apache.org/r/63842/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
