----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63377/#review191087 -----------------------------------------------------------
src/resource_provider/storage/paths.hpp Lines 31-34 (patched) <https://reviews.apache.org/r/63377/#comment268679> Consider changing this comment to refer back to `src/slave/paths.hpp`. Specifically `getResourceProviderAgentRootDir`. ``` // root (<work_dir>/resource_providers/<type>/<name>/) ``` It looks like the `rootDir` parameters below all expect an input which includes those elements. src/resource_provider/storage/paths.cpp Lines 87-88 (patched) <https://reviews.apache.org/r/63377/#comment268680> It's still a good idea to use `os::temp` even if that means some configurations will fail to create unix sockets. Instead of hardcoding `/tmp`, just check if the resulting path is too long and error out here. - Joseph Wu On Nov. 3, 2017, 5:58 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63377/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2017, 5:58 p.m.) > > > Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-8141 > https://issues.apache.org/jira/browse/MESOS-8141 > > > Repository: mesos > > > Description > ------- > > A storage resource provider can now store the following persistent CSI > data in `<work_dir>/resource_providers/<type>/<name>/csi`: > > 1. Mount points of CSI volumes: `volumes/<volume_id>` > 2. States of CSI volumes: `states/<volume_id>/state` > 3. Directory to place CSI endpoints: `/tmp/mesos-csi-XXXXXX`, which > would be symlinked by `plugins/<plugin_name>/endpoint`. > > > Diffs > ----- > > src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 > src/resource_provider/storage/paths.hpp PRE-CREATION > src/resource_provider/storage/paths.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/63377/diff/2/ > > > Testing > ------- > > make > > > Thanks, > > Chun-Hung Hsiao > >
