----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191133 -----------------------------------------------------------
src/checks/tcp_connect.cpp Line 86 (original), 84 (patched) <https://reviews.apache.org/r/63795/#comment268747> We usually call these variables like the action we performed, i.e., s/ip/parse. In this case you can also restore original argument names : ) src/checks/tcp_connect.cpp Lines 98-102 (patched) <https://reviews.apache.org/r/63795/#comment268744> Let's explicitly check for `AF_INET6` and add another `else` where we error out for unsupported family. - Alexander Rukletsov On Nov. 14, 2017, 1:30 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63795/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2017, 1:30 p.m.) > > > Review request for mesos, Alexander Rukletsov and Avinash sridharan. > > > Bugs: MESOS-8050 > https://issues.apache.org/jira/browse/MESOS-8050 > > > Repository: mesos > > > Description > ------- > > Made `mesos-tcp-connect` support IPv6. > > > Diffs > ----- > > src/checks/tcp_connect.cpp 2514f4aebcc634b18cd2b3c36529222fe456e903 > > > Diff: https://reviews.apache.org/r/63795/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
