> On Nov. 22, 2017, 8:16 p.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Lines 90 (patched) > > <https://reviews.apache.org/r/63795/diff/3/?file=1896772#file1896772line92> > > > > Should have bought this up earlier. I think this code will be a lot > > more simpler if you use `network::Address` to represent the ip:port address. > > > > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/include/process/address.hpp#L277 > > > > You wouldn't need to maintain family specific code here and you can > > directly use the > > `sock_storage` cast operator > > > > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/include/process/address.hpp#L377
Good idea! - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191722 ----------------------------------------------------------- On Nov. 22, 2017, 11:14 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63795/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 11:14 p.m.) > > > Review request for mesos, Alexander Rukletsov and Avinash sridharan. > > > Bugs: MESOS-8050 > https://issues.apache.org/jira/browse/MESOS-8050 > > > Repository: mesos > > > Description > ------- > > Made `mesos-tcp-connect` support IPv6. > > > Diffs > ----- > > src/checks/tcp_connect.cpp 2514f4aebcc634b18cd2b3c36529222fe456e903 > > > Diff: https://reviews.apache.org/r/63795/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
