----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/#review191138 -----------------------------------------------------------
src/resource_provider/storage/provider.cpp Lines 124 (patched) <https://reviews.apache.org/r/63021/#comment268755> Usually a bad idea to use Path helpers with URIs. Mostly because... Windows... I doubt SLRP items will reach Windows before we have an actual URI class with helpers, so it should be alright to leave a TODO here. src/resource_provider/storage/provider.cpp Lines 130-141 (patched) <https://reviews.apache.org/r/63021/#comment268754> Hm... Can't you use this? http://www.cplusplus.com/reference/algorithm/find/ src/resource_provider/storage/provider.cpp Lines 272-275 (patched) <https://reviews.apache.org/r/63021/#comment268756> Does this mean we need to manually update this version each time we bump the CSI 3rdparty bundle? src/resource_provider/storage/provider.cpp Lines 394 (patched) <https://reviews.apache.org/r/63021/#comment268757> Whoops, double period.. - Joseph Wu On Nov. 14, 2017, 6:40 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63021/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2017, 6:40 p.m.) > > > Review request for mesos, James DeFelice, Jie Yu, Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-8032 > https://issues.apache.org/jira/browse/MESOS-8032 > > > Repository: mesos > > > Description > ------- > > The `getService()` method first checks if there is already a container > daemon for the specified plugin, and creates a new one if not. The > post-start hook for the container daemon will call `connect()` to > wait for the endpoint socket file to appear and connect to it, then > set up the corresponding promise of CSI client. The post-stop hook will > remove the socket file and create a new promise for the next call to the > post-start hook to set it up. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > 46224997430ac0c568904d80014166a6f059907f > > > Diff: https://reviews.apache.org/r/63021/diff/8/ > > > Testing > ------- > > > Thanks, > > Chun-Hung Hsiao > >
