> On Oct. 20, 2017, 12:26 a.m., Jie Yu wrote: > > src/resource_provider/storage/provider.cpp > > Lines 236 (patched) > > <https://reviews.apache.org/r/63021/diff/5/?file=1863243#file1863243line237> > > > > YOu should follow `src/launcher/default_executor.cpp` to see how to do > > reliable registration (`doReliableRegistration`). > > > > So basically, you need to keep a state in this process, and set it > > SUBSCRIBED once you received Subscribed message. You need to retry to make > > it reliable.
Fixed in r63823 - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/#review188726 ----------------------------------------------------------- On Nov. 22, 2017, 8:47 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63021/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 8:47 a.m.) > > > Review request for mesos, James DeFelice, Jie Yu, Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-8032 > https://issues.apache.org/jira/browse/MESOS-8032 > > > Repository: mesos > > > Description > ------- > > The `getService()` method first checks if there is already a container > daemon for the specified plugin component, and creates a new one if not. > The post-start hook for the container daemon will call `connect()` to > wait for the endpoint socket file to appear and connect to it, then > set up the corresponding promise of CSI client. The post-stop hook will > remove the socket file and create a new promise for the next call to the > post-start hook to set it up. > > > Diffs > ----- > > include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 > src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc > src/resource_provider/storage/provider.cpp > 46224997430ac0c568904d80014166a6f059907f > > > Diff: https://reviews.apache.org/r/63021/diff/10/ > > > Testing > ------- > > > Thanks, > > Chun-Hung Hsiao > >
