----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/#review191201 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/os/posix/copyfile.hpp Lines 45 (patched) <https://reviews.apache.org/r/60621/#comment268849> The backslash at the end check seems a bit odd. Doesn't `isdir` return `true` if `/foo/bar/` is a directory? We also wouldn't be catching other cases like `/foo/bar/.` here, right? 3rdparty/stout/include/stout/os/posix/copyfile.hpp Lines 65 (patched) <https://reviews.apache.org/r/60621/#comment268850> I believe this is equivalent to ``` if (!WSUCCEEDED(status)) ``` 3rdparty/stout/include/stout/os/windows/copyfile.hpp Lines 46-47 (patched) <https://reviews.apache.org/r/60621/#comment268851> This message doesn't seem to have single-quotes around the paths whereas the POSIX version does. - Michael Park On Nov. 6, 2017, 10:08 a.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60621/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 10:08 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, Li > Li, and Michael Park. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > The os::copyfile() method provides an API to copy a file from one > location to another. Note that copying of directories are not > supported, and that the destination directory must exist before a > file can be copied into a directory. > > > Diffs > ----- > > 3rdparty/stout/Makefile.am 4386017acd6ca465be3f735460c11d50b440ccc5 > 3rdparty/stout/include/Makefile.am bdd3e9908ebfc682458a3babc34cbee36ad3f751 > 3rdparty/stout/include/stout/os/copyfile.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/posix/copyfile.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/copyfile.hpp PRE-CREATION > 3rdparty/stout/tests/CMakeLists.txt > 6e5773f1e03671de7ac007caf49edd0f1cd7aedd > 3rdparty/stout/tests/os/copyfile_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60621/diff/6/ > > > Testing > ------- > > See upstream > > Note that Joe made some changes to this, I ended up taking his changes as is. > > > Thanks, > > Jeff Coffler > >
