----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/#review191269 -----------------------------------------------------------
Fix it, then Ship it! src/hdfs/hdfs.cpp Line 119 (original), 119 (patched) <https://reviews.apache.org/r/60626/#comment268999> i'd kill this line to be consistent with others. src/hdfs/hdfs.cpp Lines 134 (patched) <https://reviews.apache.org/r/60626/#comment269000> Please put `+` to the end of the line above - Jie Yu On Nov. 6, 2017, 6:09 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60626/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 6:09 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, Li > Li, and Michael Park. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Windows doesn't support os::shell calls, so reworked the code to use > libprocess instead. > > > Diffs > ----- > > src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4 > > > Diff: https://reviews.apache.org/r/60626/diff/6/ > > > Testing > ------- > > See upstream > > > Thanks, > > Jeff Coffler > >
