----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review191277 -----------------------------------------------------------
src/slave/http.hpp Lines 306 (patched) <https://reviews.apache.org/r/56722/#comment269014> why isn't it a `ContentType acceptType,`? src/slave/http.cpp Lines 2296 (patched) <https://reviews.apache.org/r/56722/#comment269019> why do you need it? src/slave/http.cpp Lines 2299 (patched) <https://reviews.apache.org/r/56722/#comment269020> instead of passing in the `acceptType`, we might want to pass the containerId and construct the error msg with the containerID. src/slave/http.cpp Lines 2301 (patched) <https://reviews.apache.org/r/56722/#comment269035> could we add more log? (like `Http::_killContainer()`) src/slave/http.cpp Lines 2302-2304 (patched) <https://reviews.apache.org/r/56722/#comment269038> one thing to notice is that the current interface returns `Future<Nothing>`, so we dont have a way to distringuish a `failure` or `user need to drain all containers`. maybe add a TODO? - Gilbert Song On Nov. 15, 2017, 8:03 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56722/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2017, 8:03 p.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-4945 > https://issues.apache.org/jira/browse/MESOS-4945 > > > Repository: mesos > > > Description > ------- > > Added a new operator API for `PRUNE_IMAGES`. > > > Diffs > ----- > > include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b > include/mesos/v1/agent/agent.proto 012ffef5f0dd7720fa95ae484c99479aaf256d7b > src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3 > src/slave/http.cpp 394e91013dc11e0a79e2e00534864281cc74ad2f > src/slave/validation.cpp 32781fd8f124f71e61744804aec3fe4da59a5df2 > > > Diff: https://reviews.apache.org/r/56722/diff/6/ > > > Testing > ------- > > 1. New unit test to trigger the new call. > 2. Manually tested that images previous pulled but not running can be purged > through new operator API call while active images (running or being pulled) > are not affected. > > > Thanks, > > Zhitao Li > >
