----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63901/#review191363 -----------------------------------------------------------
include/mesos/agent/agent.proto Lines 82 (patched) <https://reviews.apache.org/r/63901/#comment269144> I'd remove the `_CONFIG` suffix. Using a config file is really a internal impl. details. include/mesos/agent/agent.proto Lines 277-278 (patched) <https://reviews.apache.org/r/63901/#comment269145> update the config file and trigger a reload is really impl. details. No need to mention that in the API doc. From API's perspective, this API will update a RP. The new RP info is provided in the payload. include/mesos/agent/agent.proto Lines 281 (patched) <https://reviews.apache.org/r/63901/#comment269147> Again, I won't mention the impl. details here. You should just say: if a resource provider with the same type and name already exist, this call will update it. If not, this call will create it. include/mesos/agent/agent.proto Lines 313 (patched) <https://reviews.apache.org/r/63901/#comment269148> If we ask operator to specify the full RP info, do we actually check if the RP info matches? or we ignore the rest of the field, just looking at type and name? look like in the comment, you mention that only type and name will be looked at. If that's the case, can we just have type and name in the payload? - Jie Yu On Nov. 17, 2017, 7:08 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63901/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 7:08 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, Joseph > Wu, and Jan Schlicht. > > > Bugs: MESOS-8244 > https://issues.apache.org/jira/browse/MESOS-8244 > > > Repository: mesos > > > Description > ------- > > WIP: Added operator API to update and remove resource provider configs. > > > Diffs > ----- > > include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b > > > Diff: https://reviews.apache.org/r/63901/diff/2/ > > > Testing > ------- > > > Thanks, > > Chun-Hung Hsiao > >
