> On Nov. 17, 2017, 5:37 p.m., Jie Yu wrote: > > include/mesos/agent/agent.proto > > Lines 82 (patched) > > <https://reviews.apache.org/r/63901/diff/2/?file=1896631#file1896631line82> > > > > I'd remove the `_CONFIG` suffix. Using a config file is really a > > internal impl. details.
I'll keep the suffix to explicitly say that these API calls are for managing config files under the resource provider config dir, as we discussed offline. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63901/#review191363 ----------------------------------------------------------- On Nov. 17, 2017, 7:08 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63901/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 7:08 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, Joseph > Wu, and Jan Schlicht. > > > Bugs: MESOS-8244 > https://issues.apache.org/jira/browse/MESOS-8244 > > > Repository: mesos > > > Description > ------- > > WIP: Added operator API to update and remove resource provider configs. > > > Diffs > ----- > > include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b > > > Diff: https://reviews.apache.org/r/63901/diff/2/ > > > Testing > ------- > > > Thanks, > > Chun-Hung Hsiao > >
