> On Nov. 16, 2017, 6:38 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/windows.hpp > > Lines 346-348 (original), 346-348 (patched) > > <https://reviews.apache.org/r/63859/diff/1/?file=1893971#file1893971line346> > > > > We should add a link to MSDN explaining why these are now set the way > > they are.
The comment above says that the flags are defined by `<sys/signal.h>` on Linux, but the actual values were wrong until I fixed them. These signals don't have real values on Windows, since Windows only supports `SIGABRT`, `SIGFPE`, `SIGILL`, `SIGINT`, `SIGSEGV`, and `SIGTERM`. > On Nov. 16, 2017, 6:38 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/windows.hpp > > Line 377 (original), 378 (patched) > > <https://reviews.apache.org/r/63859/diff/1/?file=1893971#file1893971line378> > > > > Should this be a static cast? yep - Akash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/#review191213 ----------------------------------------------------------- On Nov. 16, 2017, 6:17 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63859/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2017, 6:17 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and John Kordich. > > > Bugs: MESOS-7342 > https://issues.apache.org/jira/browse/MESOS-7342 > > > Repository: mesos > > > Description > ------- > > Fixed signal vals & WEXITSTATUS on Windows stout. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows.hpp > 7aa0ba72c4cc3b688ce6374b3308945ea8cb7572 > > > Diff: https://reviews.apache.org/r/63859/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/63862/ for test results. > > > Thanks, > > Akash Gupta > >
