> On Nov. 18, 2017, 3:25 a.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Lines 1972 (patched) > > <https://reviews.apache.org/r/63910/diff/1/?file=1896789#file1896789line1982> > > > > What is `local mode`? :)
That is not something added or modified in this patch :-) In `src/tests/health_check_tests.cpp`, I only removed 3 existing tests, and added 3 new tests, but did not change any other tests, so I think it is better to leave the unrelated tests untouched in this patch. I am not sure why the code diff of this patch looks in this way, sorry for the confusion. > On Nov. 18, 2017, 3:25 a.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Lines 2040 (patched) > > <https://reviews.apache.org/r/63910/diff/1/?file=1896789#file1896789line2069> > > > > Feels like we should have a helper function for this, similar to > > `createTask`? Ditto. > On Nov. 18, 2017, 3:25 a.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Line 2043 (original), 2050 (patched) > > <https://reviews.apache.org/r/63910/diff/1/?file=1896789#file1896789line2079> > > > > why s/->/get()? Ditto. > On Nov. 18, 2017, 3:25 a.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Line 2062 (original), 2070 (patched) > > <https://reviews.apache.org/r/63910/diff/1/?file=1896789#file1896789line2099> > > > > Not yours but s/mesos/Mesos Ditto. > On Nov. 18, 2017, 3:25 a.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Line 2080 (original), 2077 (patched) > > <https://reviews.apache.org/r/63910/diff/1/?file=1896789#file1896789line2117> > > > > s/CMD/command Ditto. > On Nov. 18, 2017, 3:25 a.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Line 2268 (original), 2308 (patched) > > <https://reviews.apache.org/r/63910/diff/1/?file=1896789#file1896789line2376> > > > > This test is a user network test, so we technically don't need to do > > this. We could set the port statically since the container is going to get > > its own network namespace. Good catch! > On Nov. 18, 2017, 3:25 a.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Line 2272 (original), 2312 (patched) > > <https://reviews.apache.org/r/63910/diff/1/?file=1896789#file1896789line2380> > > > > Just a thought: Can we just use `nginx:alpine` image? We won't need to > > rely on `nc` to do this stuff. It would work cleanly since the container is > > on its network namespace. I thought about that before, but unfortunately I found `nginx:alpine` can only work over IPv4 even IPv6 is enabled in the Docker container. > On Nov. 18, 2017, 3:25 a.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Lines 2450 (patched) > > <https://reviews.apache.org/r/63910/diff/1/?file=1896789#file1896789line2558> > > > > We should try and see if we can publish this image to > > :https://hub.docker.com/u/mesos/ > > > > Also, I assuming this a custorm image. We should commit the > > `Dockerfile` for this image to our test repo. More importantly want to the > > cert being used in this test to be part of the repo. Agree, do you know who has the permission to publish image to https://hub.docker.com/u/mesos/? And for the Dockerfile & the cert (and even the Python code `https_server.py`), I think we can just put them in the description of the Docker image so that we can see all of them in the same place. > On Nov. 18, 2017, 3:25 a.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Lines 2525 (patched) > > <https://reviews.apache.org/r/63910/diff/1/?file=1896789#file1896789line2648> > > > > As you mentioned, given that this test is identical to the HTTP test > > above, can we just parameterize the `HealthCheck.type` field as well in the > > above test case? Yeah, I thought about that before, but the problem is, besides `ROOT_DOCKER_USERNETWORK_HealthyTaskViaHTTP` and `ROOT_DOCKER_USERNETWORK_HealthyTaskViaTCP`, we have another test `ROOT_DOCKER_USERNETWORK_HealthyTaskViaHTTPS`, I am not sure how it can work if we parameterize the `HealthCheck.type` field as well. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review191375 ----------------------------------------------------------- On Nov. 17, 2017, 9:35 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63910/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 9:35 p.m.) > > > Review request for mesos, Alexander Rukletsov and Avinash sridharan. > > > Bugs: MESOS-8050 > https://issues.apache.org/jira/browse/MESOS-8050 > > > Repository: mesos > > > Description > ------- > > Removed 3 tests which only run on IPv4 Docker network. > ROOT_DOCKER_DockerHealthyTaskViaHTTP > ROOT_DOCKER_DockerHealthyTaskViaHTTPS > ROOT_DOCKER_DockerHealthyTaskViaTCP > > Added 3 tests which run on both IPv4 and IPv6 Docker networks, so they > should cover the above 3 tests. > ROOT_DOCKER_USERNETWORK_HealthyTaskViaHTTP > ROOT_DOCKER_USERNETWORK_HealthyTaskViaHTTPS > ROOT_DOCKER_USERNETWORK_HealthyTaskViaTCP > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 67945ddc4f98ffa072f584af8106967e7ff336d3 > src/tests/health_check_tests.cpp c0dcba265363f2149b217b189ee5a8e925e40ea1 > src/tests/mesos.hpp 345b883a8c629bf5bed83e9236632c277f2eb0eb > > > Diff: https://reviews.apache.org/r/63910/diff/1/ > > > Testing > ------- > > Ran all newly added tests repeatedly (20 times), they all succeeded. > > > Thanks, > > Qian Zhang > >
