> On Nov. 27, 2017, 6:03 p.m., Alexander Rukletsov wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 4963-4964 (original), 4936-4937 (patched) > > <https://reviews.apache.org/r/63910/diff/2/?file=1897379#file1897379line4963> > > > > Swap these lines
We need to remove the containers before removing the network that the containers were using, so I swapped the lines in `Setup()` instead. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review191871 ----------------------------------------------------------- On Nov. 28, 2017, 7:12 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63910/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2017, 7:12 p.m.) > > > Review request for mesos, Alexander Rukletsov and Avinash sridharan. > > > Bugs: MESOS-8050 > https://issues.apache.org/jira/browse/MESOS-8050 > > > Repository: mesos > > > Description > ------- > > Removed 3 tests which only run on IPv4 Docker network. > ROOT_DOCKER_DockerHealthyTaskViaHTTP > ROOT_DOCKER_DockerHealthyTaskViaHTTPS > ROOT_DOCKER_DockerHealthyTaskViaTCP > > Added 3 tests which run on both IPv4 and IPv6 Docker networks, so they > should cover the above 3 tests. > ROOT_DOCKER_USERNETWORK_HealthyTaskViaHTTP > ROOT_DOCKER_USERNETWORK_HealthyTaskViaHTTPS > ROOT_DOCKER_USERNETWORK_HealthyTaskViaTCP > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 67945ddc4f98ffa072f584af8106967e7ff336d3 > src/tests/health_check_tests.cpp c0dcba265363f2149b217b189ee5a8e925e40ea1 > src/tests/mesos.hpp e5c2b697a4401f010a7d77ae9acb8a9cbd3846bc > > > Diff: https://reviews.apache.org/r/63910/diff/3/ > > > Testing > ------- > > Ran all newly added tests repeatedly (20 times), they all succeeded. > > > Thanks, > > Qian Zhang > >
