----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61155/#review191471 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp Lines 2096 (patched) <https://reviews.apache.org/r/61155/#comment269312> The run loop will erase the clients as they transition, was this required? 3rdparty/libprocess/src/http.cpp Lines 2098-2100 (patched) <https://reviews.apache.org/r/61155/#comment269311> 3rdparty/libprocess/src/tests/http_tests.cpp Lines 2337 (patched) <https://reviews.apache.org/r/61155/#comment269314> Maybe a little comment about what this tests? E.g. ensures that the server does not re-order responses if handlers complete the responses out of order? 3rdparty/libprocess/src/tests/http_tests.cpp Lines 2355-2360 (patched) <https://reviews.apache.org/r/61155/#comment269313> Hopefully this will become synchronous with your update? 3rdparty/libprocess/src/tests/http_tests.cpp Lines 2419-2423 (patched) <https://reviews.apache.org/r/61155/#comment269315> Hm.. this doesn't make sure that 2 arrives before 3, wonder if there is an easy way to check that? 3rdparty/libprocess/src/tests/http_tests.cpp Lines 2436 (patched) <https://reviews.apache.org/r/61155/#comment269316> StopNotRunning? - Benjamin Mahler On July 27, 2017, 1:55 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61155/ > ----------------------------------------------------------- > > (Updated July 27, 2017, 1:55 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Added http::Server. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > ba1b086a1dba140df491387077723d5c359acbcc > 3rdparty/libprocess/src/http.cpp fa3dde68de2e543ad910febbc4c8c46309b9c147 > 3rdparty/libprocess/src/tests/http_tests.cpp > ef84967a034b6293e0279b61607c07ccc2526d99 > > > Diff: https://reviews.apache.org/r/61155/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
