----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61154/#review191486 -----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp Lines 510-513 (patched) <https://reviews.apache.org/r/61154/#comment269333> This does not compile with clang, ../3rdparty/libprocess/src/../include/process/socket.hpp:512:58: error: deleted definition must be first declaration Socket<inet::Address>::operator Try<Socket<T>>() const = delete; ^ ../3rdparty/libprocess/src/../include/process/socket.hpp:422:3: note: previous declaration is here operator Try<Socket<T>>() const; ^ ../3rdparty/libprocess/src/../include/process/socket.hpp:537:58: error: deleted definition must be first declaration Socket<unix::Address>::operator Try<Socket<T>>() const = delete; ^ ../3rdparty/libprocess/src/../include/process/socket.hpp:422:3: note: previous declaration is here operator Try<Socket<T>>() const; ^ 2 errors generated. - Benjamin Bannier On July 27, 2017, 3:55 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61154/ > ----------------------------------------------------------- > > (Updated July 27, 2017, 3:55 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Added safe downcasts for Socket. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > ae6154d5d142f65352e00f37b4e66d0b62fdc3c2 > > > Diff: https://reviews.apache.org/r/61154/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
