----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review191677 -----------------------------------------------------------
src/master/registry_operations.hpp Lines 67 (patched) <https://reviews.apache.org/r/64009/#comment269528> Double-check whether the braces should be on the same line. src/master/registry_operations.hpp Lines 93 (patched) <https://reviews.apache.org/r/64009/#comment269529> Add comment `// No mutation.` and in line 100 src/tests/registrar_tests.cpp Lines 267 (patched) <https://reviews.apache.org/r/64009/#comment269531> Add a new test to verify that applying UpdateSlave on an agent that didn't change does not crash. - Benno Evers On Nov. 21, 2017, 11:53 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64009/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 11:53 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added new UpdateSlave registry operation. > > > Diffs > ----- > > src/master/registry_operations.hpp PRE-CREATION > src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872 > > > Diff: https://reviews.apache.org/r/64009/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
