----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review192530 -----------------------------------------------------------
Fix it, then Ship it! src/master/registry_operations.cpp Line 64 (original), 70 (patched) <https://reviews.apache.org/r/64009/#comment270734> Worth adding a comment here on why you are doing this. - Vinod Kone On Dec. 1, 2017, 6:37 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64009/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 6:37 p.m.) > > > Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This operation can be used to update the stored state > of an existing, admitted slave. > > > Diffs > ----- > > src/master/registry_operations.hpp 5b78306fb2e2bd7e30200f112f0381a595c7b25d > src/master/registry_operations.cpp 1e1eadb539482113e8ca8cb0542e5aaf34a38b41 > src/tests/registrar_tests.cpp 21d78e90e57c145aa9f4b26f1a2f0278390b98d4 > > > Diff: https://reviews.apache.org/r/64009/diff/5/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >