----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63628/#review191717 -----------------------------------------------------------
Fix it, then Ship it! Looks good! 3rdparty/stout/include/stout/utils.hpp Lines 34 (patched) <https://reviews.apache.org/r/63628/#comment269602> `T... Ints` please 3rdparty/stout/include/stout/utils.hpp Lines 44-52 (patched) <https://reviews.apache.org/r/63628/#comment269601> Let's put these in `internal` namespace, and also refer to `std::size_t` consistently here. - Michael Park On Nov. 7, 2017, 8:51 a.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63628/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 8:51 a.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Bugs: MESOS-6972 > https://issues.apache.org/jira/browse/MESOS-6972 > > > Repository: mesos > > > Description > ------- > > This adds implementation of C++14 STL's `index_squence` > and `make_index_sequence` templates. > > > Diffs > ----- > > 3rdparty/stout/include/stout/utils.hpp > 82cab830817842c23056235973ec4419ee9ec8b1 > > > Diff: https://reviews.apache.org/r/63628/diff/1/ > > > Testing > ------- > > > Thanks, > > Dmitry Zhuk > >
