----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64012/#review191769 -----------------------------------------------------------
Partial review. src/Makefile.am Lines 1015 (patched) <https://reviews.apache.org/r/64012/#comment269670> CMakeLists? src/slave/flags.hpp Lines 93 (patched) <https://reviews.apache.org/r/64012/#comment269671> Remove the comment. src/slave/reconfiguration.hpp Lines 17-18 (patched) <https://reviews.apache.org/r/64012/#comment269672> this should be the same as the name of the file. s/_CONFIGURATION_COMPATIBILITY_/RECONFIGURATION/ src/slave/slave.cpp Lines 854 (patched) <https://reviews.apache.org/r/64012/#comment269673> s/state_recovery/configuration_compatibility/ src/slave/slave.cpp Lines 856 (patched) <https://reviews.apache.org/r/64012/#comment269674> Put `&&` in the line above. src/slave/slave.cpp Lines 1036-1042 (patched) <https://reviews.apache.org/r/64012/#comment269675> just EXIT here? returning here is dangerous because further detection won't happen. src/slave/slave.cpp Lines 1232-1233 (patched) <https://reviews.apache.org/r/64012/#comment269677> remove this? - Vinod Kone On Nov. 22, 2017, 11:31 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64012/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 11:31 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added new --configuration_compatibility slave flag and implementation. > > > Diffs > ----- > > src/Makefile.am 49dec55ced32945ad0414c32eb4e00247f4b54f2 > src/slave/flags.hpp 0c02b49c054ef2597298aefe0997beacfc9efeb8 > src/slave/flags.cpp 0eeecdc6023443a99c8e8fe29c2f7bf791c0a36e > src/slave/reconfiguration.hpp PRE-CREATION > src/slave/reconfiguration.cpp PRE-CREATION > src/slave/slave.hpp 40442f25ae1b223380e11f8602e6256c9203ef47 > src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0 > src/tests/reconfiguration_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/64012/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
