----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64012/#review192160 -----------------------------------------------------------
src/slave/slave.cpp Lines 6336 (patched) <https://reviews.apache.org/r/64012/#comment270185> kill this. src/slave/slave.cpp Line 6306 (original), 6340 (patched) <https://reviews.apache.org/r/64012/#comment270183> s/compatibility/_compatible/ src/slave/slave.cpp Lines 6380 (patched) <https://reviews.apache.org/r/64012/#comment270184> ```info.erase_id();``` src/slave/slave.cpp Lines 6383-6384 (patched) <https://reviews.apache.org/r/64012/#comment270186> Kill this. src/tests/cluster.hpp Lines 200 (patched) <https://reviews.apache.org/r/64012/#comment270192> no need for this. see below. src/tests/master_tests.cpp Lines 2661 (patched) <https://reviews.apache.org/r/64012/#comment270193> s/state/info/ src/tests/master_tests.cpp Lines 2663 (patched) <https://reviews.apache.org/r/64012/#comment270194> RegistryUpdateAfterReconfiguration src/tests/master_tests.cpp Lines 2675 (patched) <https://reviews.apache.org/r/64012/#comment270195> `slaveFlags` `work_dir` src/tests/master_tests.cpp Lines 2738 (patched) <https://reviews.apache.org/r/64012/#comment270196> `recover()` src/tests/master_tests.cpp Lines 2758 (patched) <https://reviews.apache.org/r/64012/#comment270197> s/reregistration/reregistration after master failover/ src/tests/master_tests.cpp Lines 2761 (patched) <https://reviews.apache.org/r/64012/#comment270198> RegistryUpdateAfterMasterFailover src/tests/master_tests.cpp Lines 2773 (patched) <https://reviews.apache.org/r/64012/#comment270199> `StartSlave()` `work_dir` src/tests/master_tests.cpp Lines 2783 (patched) <https://reviews.apache.org/r/64012/#comment270200> // Shutdown the master. src/tests/master_tests.cpp Lines 2786 (patched) <https://reviews.apache.org/r/64012/#comment270202> // Shutdown the slave. src/tests/master_tests.cpp Lines 2789 (patched) <https://reviews.apache.org/r/64012/#comment270203> // Restart the master. src/tests/master_tests.cpp Lines 2795 (patched) <https://reviews.apache.org/r/64012/#comment270204> // Restart the slave with changed resources. src/tests/master_tests.cpp Lines 2803 (patched) <https://reviews.apache.org/r/64012/#comment270205> period at the end. src/tests/slave_compatibility_tests.cpp Lines 23-24 (patched) <https://reviews.apache.org/r/64012/#comment270187> reordered. src/tests/slave_compatibility_tests.cpp Lines 111 (patched) <https://reviews.apache.org/r/64012/#comment270188> decreased. src/tests/slave_tests.cpp Lines 8813-8814 (patched) <https://reviews.apache.org/r/64012/#comment270189> update the comment to only test the success case. src/tests/slave_tests.cpp Lines 8829-8835 (patched) <https://reviews.apache.org/r/64012/#comment270191> Just wait until it's registered. then you don't need to pull out `Slave` variable in the `Cluster` to public. src/tests/slave_tests.cpp Lines 8862 (patched) <https://reviews.apache.org/r/64012/#comment270190> Add a test with resource addition -- Launch a task -- Restart slave with extra resources -- Kill the task -- Make sure the resources are offered back - Vinod Kone On Nov. 29, 2017, 7:10 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64012/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2017, 7:10 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This flag allows operators to weaken the checks performed by the agent > when recovering state, in particular it allows to recover running tasks > even when parts of the recovered SlaveInfo don't match the current > state. > > The set of possible changes is quite restricted for now, > to avoid accidenetally introducing semantic bugs. > > > Diffs > ----- > > src/CMakeLists.txt be212d9316e1b8a605b2f7f2cdaae37a3b0871bf > src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8 > src/slave/compatibility.hpp PRE-CREATION > src/slave/compatibility.cpp PRE-CREATION > src/slave/flags.hpp f25d8aff29d0698eaf06dd40a86a35e43bc9e094 > src/slave/flags.cpp 7998d9bb66995ad0d1285fcb1042321afdf917a9 > src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059 > src/slave/slave.cpp e1566832f90cca372ad2f1cc13d1e7f76fa53285 > src/tests/CMakeLists.txt 8997cc0f762aa27decaa24a147a8581549a82e80 > src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9 > src/tests/master_tests.cpp 01f45a9bb6378c5fded31bf58fbcad93fe7ed719 > src/tests/slave_compatibility_tests.cpp PRE-CREATION > src/tests/slave_tests.cpp aeaa923f36af134b61ad9df93c95651a8d9bc23c > > > Diff: https://reviews.apache.org/r/64012/diff/4/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
