----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ -----------------------------------------------------------
(Updated Nov. 27, 2017, 5:37 p.m.) Review request for mesos, Andrew Schwartzmeyer and John Kordich. Changes ------- Rebased and changed host mode to nat mode on Windows. Bugs: MESOS-7342 https://issues.apache.org/jira/browse/MESOS-7342 Repository: mesos Description (updated) ------- The current Network enum in DockerInfo is specific to Linux containers. Instead of supporting {host, bridge, none, user} networks, Windows docker supports {nat, none, user} networks. Now, if the host or bridge network type is sent to the Windows agent, it will be internally converted to nat. Diffs (updated) ----- src/docker/docker.cpp 722a54ad113fc4e2bb22a8f08e307ab38d5fbfed Diff: https://reviews.apache.org/r/63860/diff/3/ Changes: https://reviews.apache.org/r/63860/diff/2-3/ Testing ------- See https://reviews.apache.org/r/63862/ for test results. Thanks, Akash Gupta