-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63860/
-----------------------------------------------------------
(Updated Dec. 7, 2017, 12:04 p.m.)
Review request for mesos, Andrew Schwartzmeyer and John Kordich.
Changes
-------
Added `NAT` field to protobuf and now use the protobuf `hasXXX()` field to
determine the default network value.
Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342
Repository: mesos
Description (updated)
-------
The current Network enum in DockerInfo is specific to Linux containers.
Instead of supporting {host, bridge, none, user} networks, Windows
docker supports {nat, none, user} networks. Now, the Network enum
supports {host, bridge, nat, none, user}. If the network isn't
specified, then the default is host on Linux and nat on Windows.
Diffs (updated)
-----
include/mesos/mesos.proto 839ddb1cb41471d36423a2fc149acf90b973d413
src/docker/docker.cpp 722a54ad113fc4e2bb22a8f08e307ab38d5fbfed
Diff: https://reviews.apache.org/r/63860/diff/4/
Changes: https://reviews.apache.org/r/63860/diff/3-4/
Testing
-------
See https://reviews.apache.org/r/63862/ for test results.
Thanks,
Akash Gupta
