----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/#review191955 -----------------------------------------------------------
include/mesos/allocator/allocator.hpp Lines 219 (patched) <https://reviews.apache.org/r/64010/#comment269906> lets not take an option here, but just `SlaveInfo&` src/master/allocator/mesos/allocator.hpp Lines 106 (patched) <https://reviews.apache.org/r/64010/#comment269907> s/reset/remove/ src/master/allocator/mesos/allocator.hpp Lines 249 (patched) <https://reviews.apache.org/r/64010/#comment269908> s/reset/remove/ src/master/allocator/mesos/allocator.hpp Lines 482-494 (patched) <https://reviews.apache.org/r/64010/#comment269909> remove this? src/master/allocator/mesos/hierarchical.hpp Lines 548 (patched) <https://reviews.apache.org/r/64010/#comment269911> s/resets/removes/ src/master/allocator/mesos/hierarchical.hpp Lines 550 (patched) <https://reviews.apache.org/r/64010/#comment269910> s/reset/remove/ src/master/allocator/mesos/hierarchical.cpp Lines 662-677 (patched) <https://reviews.apache.org/r/64010/#comment269914> ``` Option<DomainInfo> newDomain = info->hasDomain() : info->Domain() : None(); if (previousDomain != newDomain) { updated = true; slave.domain = newDomain; } ``` src/master/allocator/mesos/hierarchical.cpp Lines 1343 (patched) <https://reviews.apache.org/r/64010/#comment269916> "Removed all filters for slave " - Vinod Kone On Nov. 27, 2017, 11:29 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64010/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2017, 11:29 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This allows callers to inform the allocator that an existing agents > SlaveInfo changed, probably because it was restarted and reregistered > with the same id. > > Additionally, this also provides callers with an option to reset > existing offer filters for a given slave id when the update is > applied. > > While the existing HierarchicalDRFAllocator only cares about the domain > and hostname fields, we still have to pass the full SlaveInfo here > because custom allocators might base their decisions on other fields, > for example attributes. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > ae122003487ca8956573e993cd3993aa8cc286f1 > src/master/allocator/mesos/allocator.hpp > 8fa4fdeec4ec64bcd49fc442c230d8684a11cfd9 > src/master/allocator/mesos/hierarchical.hpp > 2c4832b29842330fa57756cd3d4202f265a820f3 > src/master/allocator/mesos/hierarchical.cpp > cfeeb3bfa3ad7d78ff6e22cfc4adb1f0efa05629 > src/tests/allocator.hpp 6a84f1beb86dceb5a5e9bf4615c13a216f3d0905 > src/tests/hierarchical_allocator_tests.cpp > f0f95ba4f667bf8ea54e985d8cde913a4170d8ff > > > Diff: https://reviews.apache.org/r/64010/diff/3/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
