> On Nov. 29, 2017, 12:54 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 284-304 (original), 284-304 (patched) > > <https://reviews.apache.org/r/64136/diff/1/?file=1902750#file1902750line284> > > > > There is similar code for tracking the allocation, this is another > > spot, is there any reason for not calling into it here?
Good catch. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64136/#review192078 ----------------------------------------------------------- On Nov. 29, 2017, 5:27 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64136/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2017, 5:27 p.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This patch introduces a helper to track allocated resources. It > encapsulates all needed updates to the various sorters for > reusability. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2c4832b29842330fa57756cd3d4202f265a820f3 > src/master/allocator/mesos/hierarchical.cpp > 5ce9ceaa3a5f84a1e076d45448863c418531cc2b > > > Diff: https://reviews.apache.org/r/64136/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
